Opened on 01/26/2015 at 09:37:26 AM
Closed on 02/10/2015 at 11:05:19 AM
#1868 closed defect (fixed)
"Block element" cannot handle <area> elements
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): |
http://codereview.adblockplus.org/6022881116946432 |
||
Description
How to reproduce
- Go to http://thewml.org/example/demo/d_incl_imp_csmap/demo.html
- Click the ABP icon
- Choose "Block element"
- Click the image
Observed behaviour
The image is neither highlighted nor does the dialog to add filters show up. Note that <area> elements are used to divide the image into clickable areas.
Expected behaviour
The image should be highlighted and upon clicking the dialog should show up suggesting to add a filter to block that image.
Attachments (0)
Change History (5)
comment:1 Changed on 01/26/2015 at 10:57:00 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/27/2015 at 10:55:03 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 01/28/2015 at 10:06:29 AM by sebastian
- Resolution fixed deleted
- Status changed from closed to reopened
The fix implemented doesn't work with the "Block element" context menu item.
comment:4 Changed on 01/28/2015 at 10:08:39 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:5 Changed on 02/10/2015 at 11:05:19 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/798a1492b3c1