Opened on 03/10/2015 at 06:11:06 PM
Closed on 04/15/2015 at 09:20:15 AM
Last modified on 05/14/2015 at 03:22:04 PM
#2120 closed change (fixed)
[adblockplus.org Anwiki to CMS migration] implement animations
Reported by: | saroyanm | Assignee: | kzar |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Websites | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #2035 | Platform: | Unknown |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | yes | |
Review URL(s): |
http://codereview.adblockplus.org/4661048523096064/ |
Description (last modified by kzar)
Background
In Anwiki we have a special animation tag. Anwiki loads the animation.js script on any page that uses it.
Also, each animation has a xml document with animation instructions, these instructions are loaded based on the name attribute of animation tag.
What to change
adblockplus-website-converter:
- Update the refresh-static-files script to download https://adblockplus.org/animation.js.
- Update the convert.py script to process files starting with animation! in a similar way to how interfaces, pages etc are processed. Output should mostly match the XML served by Anwiki. (However _don't_ update image <object> tags to use data URLs, instead wrap the src URL with a call to the inline_image filter.)
- Update the convert.py script so that animation.js is included on any page that contains an <animation> tag.
web.adblockplus.org
- Add a filter called inline_image that takes an image path and returns a data URL of the image's contents. Be sure to allow both localised (eg static/image/example.png) and non-localised (eg locales/en/images/example.png) images.
Attachments (0)
Change History (7)
comment:1 Changed on 04/08/2015 at 08:25:01 AM by kzar
- Owner set to kzar
- Verified working unset
comment:4 Changed on 04/09/2015 at 08:41:36 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 04/15/2015 at 09:20:15 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/07/2015 at 11:52:03 AM by kzar
https://github.com/kzar/adblockplus-website-converter/commit/218fa07aed032b0d47254a1ff0b3a1a7dc3bdca6
https://github.com/kzar/adblockplus-website-converter/commit/123cbdffd39e24e7cb4a920aa2473e3bc31667d2
https://github.com/kzar/adblockplus-website-converter/commit/47e219311a02c0beed67b9fd4cebec9c7ef29cd4
https://github.com/kzar/adblockplus-website-converter/commit/892b207c4fe24ad624bf7ffbd98b25b34fb175ec
https://github.com/kzar/adblockplus-website-converter/commit/cd75f354ef7d23887762bb00e202aab2d4602ad6
https://github.com/kzar/adblockplus-website-converter/commit/9df789adc834d3d22a75269c1f030a475a7645c7
https://github.com/kzar/adblockplus-website-converter/commit/aded24bc9b782c7dc02ed4180232ee75edd247d1
https://github.com/kzar/adblockplus-website-converter/commit/3c9c4c419727f0d7eecdd221bfe5b981e1d586bd
https://github.com/kzar/adblockplus-website-converter/commit/35457ff57c4e6fc4d430e9b54e9022f37b7d2c03
https://github.com/kzar/adblockplus-website-converter/commit/687d41ce4865982f652cfbe107d14dcaa122da94
https://github.com/kzar/adblockplus-website-converter/commit/22db3fb960a8d822e1d1e5705eaaa215cca7d69a
comment:7 Changed on 05/14/2015 at 03:19:19 PM by Ross
- Verified working set
Implemented and working except in IE9 (opened as #2519).
Tested by:
Checking animations work/play on the FAQ pages.
Tested on:
https://beta.adblockplus.org/en/faq_basics#blocking
Tested with:
IE | 8.0.6001 | Windows XP |
IE | 9.0.8112 | Windows 7 |
IE | 10.0.9200 | Windows 7 |
IE | 11.0.9600 | Windows 8.1 |
Chrome | 42.0.2311.135 | Windows 8.1 |
Opera | 29.0.1795.47 | Windows 8.1 |
Firefox | 37.0.2 | Windows 8.1 |
Safari | 7.0 | OSX 10.9 |
Chrome | 42.0.3211.111 | Android 4.4.2 |
Firefox Mobile | 29.0.1 | Android 4.4.2 |
Browser | 4.4.2-15 | Android 4.4.2 |
Unfortunately there's more to this than copying the files over, Anwiki appears to process the XML files. For example compare the anim_addicon.xml that is served online to the one under source control.
I've updated the description accordingly.