Opened on 03/12/2015 at 09:24:56 PM

Closed on 03/13/2015 at 02:07:46 PM

Last modified on 05/14/2015 at 10:31:27 AM

#2136 closed change (fixed)

[adblockplus.org Anwiki to CMS migration] Update web.adblockplus.org content for specifying default translations inline

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: Blocked By:
Blocking: #2035, #2105 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

​http://codereview.adblockplus.org/6250108710551552/

Description

Background

#2133 changed the way strings are referred to in pages, web.adblockplus.org content needs to be adapted accordingly.

What to change

Update conversion script and change usage of translate filter in the manually modified templates.

Attachments (0)

Change History (4)

comment:1 Changed on 03/12/2015 at 09:29:45 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/13/2015 at 02:07:46 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed:

​https://hg.adblockplus.org/web.adblockplus.org/rev/cd35a11e2c32
​https://hg.adblockplus.org/web.adblockplus.org/rev/7e67e1e36c87

comment:3 Changed on 03/13/2015 at 02:17:54 PM by trev

  • Blocking 2105 added

comment:4 Changed on 05/14/2015 at 10:31:27 AM by Ross

  • Verified working set

Implemented and working. Default translations are now specified inline.

Tested by:
Checking the data in web.adblockplus.org. Also running the website converter script as per the read me and checking the output.

Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.