[adblockplus.org Anwiki to CMS migration] Translatable links handled incorrectly

[trev]

Background

Whenever an href attribute had to be translatable, a construct like <a><attr name="href">http://example/</attr>Link</a> had to be used. Since Anwiki can only translate text content, the attribute value was put inside a special <attr> tag. The conversion script will currently turn these attributes into content that cannot be translated.

What to change

Make sure that attributes like in the example are added to localization files properly and can be translated. This requires syntax like $string($link$)$ to be supported by the CMS first.

[kzar]

After ​playing around with the code a little I've come to the conclusion this issue isn't clear enough yet. Questions I have:

• Are we only talking about href attribute for <a> tags, if so let's say that. If not let's clarify exactly what the problem is.
• What exactly should happen? Currently the contents of the <attr> tag gets squashed onto the parent <a> tag, which breaks translatable attributes but avoids strings being broken up as much. How can we fix the former without breaking the later?

If this ticket is only about href attributes for <a> tags I figured we could generate something like this: "$s4($s5$)$" where s4 is "Test <a>link</a> text" and s5 is a URL. Problem is that syntax doesn't seem to be supported by sitescripts.cms, when I tried it I got this rendered as a result "$s4(​http://google.com)$".

So as I'm not clear on exactly what the issue is looking to address or how we plan to address it I'm removing the ready flag for now.

[trev]

This was fixed as a side-effect of #2136. However, currently translatable links will break up sentences - #2140 is about fixing this.

[Ross]

Working.

Tested by:
Running the website converter script as per the read me and checking the output for translatable links.

Tested with:
www / r18024
sitescripts / r501
web.adblockplus.org / r68
website-converter / master / 105208883c4336a3788820fe9ab379cf639f8387