Opened on 03/13/2015 at 07:43:52 PM
Closed on 03/13/2015 at 08:10:44 PM
Last modified on 05/15/2015 at 05:02:43 AM
#2144 closed defect (fixed)
[adblockplus.org Anwiki to CMS migration] get_subscriptions filter expects a local subscriptionlist repository
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
How to reproduce
- Run test server on a computer without a sitescripts.ini file.
- Open http://localhost:5000/en/subscriptions
Observed behaviour
An error message complains about a missing sitescripts.ini file.
Expected behaviour
The page should show up correctly.
Background
get_subscriptions filter uses sitescripts.subscriptions.subscriptionParser. This module currently expects to work with a local subscriptionlist repository. While we already override this behavior when it comes to retrieving the list of subscriptions, it still tries to get a settings file from a local (and non-existent) repository.
What to change
Patch up sitescripts.subscriptions.subscriptionParser to download the file from https://hg.adblockplus.org/subscriptionlist/rawfile/default/settings.
Attachments (0)
Change History (3)
comment:1 Changed on 03/13/2015 at 07:45:16 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/13/2015 at 08:10:44 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 05/15/2015 at 05:02:43 AM by Ross
- Verified working set
Fixed/done.
Tested by:
Running a test server without sitescripts.ini. It downloads required files successfully and displays the subscriptions page.
Fixed: https://hg.adblockplus.org/web.adblockplus.org/rev/226f5673260a