Opened on 03/16/2015 at 03:12:42 AM

Closed on 06/13/2018 at 10:08:35 AM

Last modified on 08/20/2019 at 07:57:28 AM

#2148 closed change (fixed)

Rewrite the testpages test suite

Reported by: Ross Assignee: Ross
Priority: P5 Milestone:
Module: Unknown Keywords:
Cc: philll, Ross Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29755578/

Description (last modified by Ross)

Background

We want static, simple, self-hosted test pages for testing various ABP filter functionality. A ​repository already exists for serving these.

What to change

  • Make layout mobile friendly.
  • Remove old test suite pages.
  • Add test cases covering all filters types and exceptions.
  • Ensure all test case filters can be active at the same time.
  • Clean up CSS.

Attachments (0)

Change History (12)

comment:1 Changed on 03/16/2015 at 11:24:06 AM by Ross

  • Description modified (diff)

Updated description to be a better specification of what is required.

Last edited on 03/16/2015 at 11:25:15 AM by Ross

comment:2 Changed on 03/18/2015 at 10:55:41 AM by Ross

  • Description modified (diff)

comment:3 Changed on 04/01/2015 at 12:49:13 PM by Ross

  • Description modified (diff)
  • Verified working unset

comment:4 Changed on 04/13/2015 at 10:45:14 PM by Ross

  • Description modified (diff)

comment:5 Changed on 07/31/2015 at 05:32:25 AM by Ross

  • Description modified (diff)
  • Ready set
  • Tester set to Ross

I've updated this ticket to match what has eventually become the first set of test suite pages. I've created other tickets for updating/improvement of the other sections: #2840 and #2841.

comment:6 Changed on 01/25/2017 at 03:21:18 PM by juliandoucette

@Ross this ticket is aging. I would suggest lowering it's priority or breaking it up into smaller chunks if it's not going to get done. Please reach out to us if you need help.

Last edited on 01/25/2017 at 03:21:36 PM by juliandoucette

comment:7 Changed on 08/30/2017 at 03:30:26 PM by juliandoucette

  • Cc Ross added
  • Priority changed from P3 to P5

comment:8 Changed on 01/30/2018 at 11:05:31 PM by juliandoucette

  • Component changed from Websites to Unknown

comment:9 Changed on 03/01/2018 at 10:10:15 AM by Ross

  • Description modified (diff)
  • Summary changed from Create initial test pages for test suite to Update test pages with testcases for filter types

comment:10 Changed on 04/18/2018 at 12:20:42 PM by Ross

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Summary changed from Update test pages with testcases for filter types to Rewrite the testpages test suite

comment:12 Changed on 06/07/2018 at 03:45:11 PM by abpbot

Some commits referencing this issue have landed:

comment:13 Changed on 06/13/2018 at 10:08:35 AM by Ross

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ross.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.