Opened on 03/16/2015 at 11:47:30 AM
Closed on 10/10/2016 at 09:44:46 AM
#2149 closed change (duplicate)
Add proper support for nsIContentPolicy.TYPE_IMAGESET
| Reported by: | trev | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
https://bugzilla.mozilla.org/show_bug.cgi?id=1055750 added a new request type called TYPE_IMAGESET. This type is used for requests performed via <img srcset=...> (currently disabled by default) and <picture> tags. Adblock Plus doesn't support that type explicitly and will map it to other which is suboptimal.
What to change
Map TYPE_IMAGESET explicitly to image so that these requests are treated just like regular image requests.
What to test
Go to about:config and make sure that dom.image.srcset.enabled and dom.image.picture.enabled preferences are set to true (double-click to toggle value). Now go to http://en.wikipedia.org/wiki/Main_Page and press Ctrl-Shift-V to open Blockable items. Without this change, many images will be listed with type "other" rather than "image". Also go to http://responsiveimages.org/demos/art-direction/index.html - without this change http://responsiveimages.org/demos/art-direction/img/iphone.png will appear both as "other" and as "image" in the list.
Made Firefox and Firefox mobile available as seperate platforms.