Opened on 03/19/2015 at 09:06:29 PM

Closed on 03/20/2015 at 04:09:17 PM

#2179 closed change (fixed)

[cms] Give Jinja2 templates a way to set global parameters

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #662 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/4923768585584640/

Description (last modified by trev)

Background

Currently, Jinja2 templates see global parameters like title as variable in their scope. However, changes to these parameters have no consequences.

What to change

Make sure that all exported variables of a template (meaning all variables defined at the top level and with variable names not prefixed with an underscore) are considered updates to the params dictionary. So setting or changing the title variable will actually make the new value visible in other templates.

Attachments (0)

Change History (3)

comment:1 Changed on 03/19/2015 at 09:30:19 PM by trev

  • Priority changed from Unknown to P3
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/20/2015 at 04:07:32 PM by trev

  • Description modified (diff)

comment:3 Changed on 03/20/2015 at 04:09:17 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/cms/rev/69260baed82e

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.