Opened on 06/12/2014 at 04:12:18 PM

Closed on 03/23/2015 at 05:49:38 PM

#662 closed change (fixed)

[eyeo.com] Job links shouldn't use anchors

Reported by: fhd Assignee: saroyanm
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: kirill@adblockplus.org, sebastian, greiner, saroyanm Blocked By: #2178, #2179, #2181
Blocking: #2131 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5994668214976512/

Description (last modified by saroyanm)

Background

We currently use job links of this form:
https://eyeo.com/jobs#web-developer

This makes it impossible for us to see how many page views individual job ads got - it all ends up as https://eyeo.com/jobs in the logs.

What to change

  1. create generic header (Ex: includes/jobs/generic-header.tmpl) and generic footer (Ex: includes/jobs/generic-footer.tmlp) for job openings page, the information about job openings should go between this generic templates.
  2. create pages/jobs.tmpl Where content of the overview page should be placed.
  3. create pages/jobs/JOBTITLEs.md for each job opening, where the content of the job should be placed.
  4. create pages/jobs/not-available with text like The position you are looking for is no longer available this page will be used to redirect users in case they open the non existing job page.

Attachments (0)

Change History (23)

comment:1 Changed on 09/17/2014 at 04:32:57 PM by trev

  • Component changed from Infrastructure to Websites

comment:2 Changed on 10/08/2014 at 10:50:19 AM by Kirill

  • Cc kirill@adblockplus.org added
  • Platform set to Unknown

comment:3 Changed on 03/04/2015 at 03:01:07 PM by saroyanm

What about using query strings ?
Something like:
https://eyeo.com/jobs?position=web-developer

@kirill will that work for you ?

comment:4 Changed on 03/04/2015 at 03:53:13 PM by saroyanm

  • Ready unset

comment:5 Changed on 03/04/2015 at 05:09:47 PM by saroyanm

  • Cc sebastian greiner added

@Sebastian would it be possible to use query string parameters value in the jinja template ?
I'm looking for similar solution:

<? include jobs/openings/{{ request.args.get("position") }} ?>

I think if we can use url parameter value, than we can have solution for current ticket, otherwise I see only current solutions:

  1. Use Javascript to parse url and show appropriate content (Which will have accessibility issues)
  2. Create separate page for each position (this will provide problems in maintaining)

I'm actually new to our CMS, so maybe there is some other option I've missed.

Last edited on 03/04/2015 at 05:10:54 PM by saroyanm

comment:6 Changed on 03/04/2015 at 05:18:58 PM by sebastian

No you can't. It's a static page generator, no dynamic web page framework. Neither would URLs with the job title given in the query string be nice. I actually realized that problem myself in the past. And started to make each job posting an own pages (this is how you would do it), but it became rather complex, that I dumped the code again.

comment:7 Changed on 03/11/2015 at 04:16:25 PM by saroyanm

  • Cc saroyanm added

Sorry, this got lost from my radar.
Yes that's a problem, so we will need to create separate page for each job opening in that case, it will make the process less manageable so Maren will need to ask us to create new job opening each time.
But I don't see other solution, also in case we will implement metadata would be nice to have separate metadatas for each job opening and beside that I think we will need to change the other pages for consistency and ability to share.

I'll open discourse discussion for that.

comment:8 Changed on 03/12/2015 at 02:17:27 PM by saroyanm

  • Description modified (diff)
  • Ready set

@Sebastian thanks for hints, the description updated.

comment:9 Changed on 03/12/2015 at 02:26:15 PM by saroyanm

  • Description modified (diff)

comment:10 Changed on 03/12/2015 at 02:47:36 PM by saroyanm

  • Description modified (diff)

comment:11 Changed on 03/12/2015 at 02:57:34 PM by saroyanm

  • Blocking 2131 added

comment:12 Changed on 03/12/2015 at 03:04:28 PM by saroyanm

  • Owner set to saroyanm

comment:13 Changed on 03/16/2015 at 11:11:29 AM by saroyanm

  • Description modified (diff)

comment:14 Changed on 03/16/2015 at 11:26:52 AM by saroyanm

  • Description modified (diff)

comment:15 Changed on 03/16/2015 at 05:51:52 PM by saroyanm

  • Description modified (diff)

comment:16 Changed on 03/17/2015 at 04:05:10 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:17 Changed on 03/17/2015 at 04:55:27 PM by saroyanm

  • Description modified (diff)

Updated the not-available page text after aligning with Maren.

comment:18 Changed on 03/19/2015 at 08:59:16 PM by trev

  • Blocked By 2178 added

comment:19 Changed on 03/19/2015 at 09:06:29 PM by trev

  • Blocked By 2179 added

comment:20 Changed on 03/19/2015 at 09:50:43 PM by trev

  • Blocked By 2180 added

comment:21 Changed on 03/19/2015 at 10:04:45 PM by trev

  • Blocked By 2181 added

comment:22 Changed on 03/20/2015 at 04:10:33 PM by trev

  • Blocked By 2180 removed

comment:23 Changed on 03/23/2015 at 05:49:38 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.