Opened on 03/26/2014 at 03:09:08 PM
Closed on 01/29/2016 at 09:05:32 PM
#219 closed defect (fixed)
Donation page broken in IE 8
Reported by: | philll | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Websites | Keywords: | |
Cc: | greiner | Blocked By: | |
Blocking: | Platform: | Internet Explorer | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by greiner)
Environment
Win 7 IE 8
How to reproduce
- Go to https://adblockplus.org/en/donate
- Select an amount by checking one of the radio buttons
- Click the "Donate" button
Observed behaviour
Nothing happens when the "Donate" button is clicked.
Expected behaviour
Like proceeding the same with another browser like Chrome, the respective payment site should open.
Attachments (0)
Change History (6)
comment:1 Changed on 04/29/2014 at 03:17:30 PM by greiner
- Description modified (diff)
- Owner set to greiner
- Status changed from new to assigned
- Summary changed from Donation page broken in IE 6,7,8 to Donation page broken in IE 8
comment:2 Changed on 04/30/2014 at 09:50:33 AM by philll
- Status changed from assigned to new
The assigned state will be dropped by #403
comment:3 Changed on 09/17/2014 at 04:48:29 PM by saroyanm
- Component changed from Infrastructure to Websites
- Platform set to Unknown
comment:4 Changed on 10/14/2014 at 03:41:28 PM by greiner
- Owner greiner deleted
comment:5 Changed on 01/20/2016 at 11:30:26 AM by juliandoucette
- Platform changed from Unknown to Internet Explorer
- Review URL(s) modified (diff)
- Status changed from new to reviewing
- Tester set to Unknown
It seems this site was generally not developed with IE<9 in mind.
This revision implements IE8 support for the donate form in donate.html in roughly
as few changes as possible. If we want to support IE8 sitewide, I would recommend
introducing a JavaScript library or select polyfills for IE<9 (which can be
included without slowing down pageload on other probsers via IFIE comments).
I found the following issues in donate.html
- IE8 doesn't support addEventListener (use attachEvent and 'on' + event)
- IE8 doesn't support DOMContentLoaded (use document readyState and onreadystatechange)
- IE8 querySelector doesn't support :checked (use querySelectorAll and a function to return the checked checkbox)
- IE8 doesn't support getElementsByClassName (use querySelectorAll)
- IE8 event doesn't have target (use event.target or event.srcElement)
- IE8 document.head is undefined (use document.getElementsByTagName('head')[0])
- #form should be a form for accessibility (to conform to web standards)
- form should submit event instead of click for accessibility (to conform to web standards)
- Node.localName was removed from Chrome as of version 46, use tagName (this is out of scope for supporting IE8, but it is related because localName will not be supported by standards in the future)
- IE8 buttons submit by default (use event.preventDefault() and event.returnValue = false)
comment:6 Changed on 01/29/2016 at 09:05:32 PM by juliandoucette
- Resolution set to fixed
- Status changed from reviewing to closed
We discontinued support for Internet Explorer 6 and 7. Therefore I modified this issue to only mention Internet Explorer 8.