Opened on 04/01/2015 at 12:08:11 PM

Closed on 04/01/2015 at 01:45:08 PM

Last modified on 05/20/2015 at 02:22:39 PM

#2255 closed defect (fixed)

IO.writeToFile() doesn't support ES6 generators

Reported by: mapx Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: sebastian, trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5825018483179520

Description (last modified by sebastian)

Environment

FF 37
ABP 2.6.9.3928 (ABP 2.6.9, stable is OK)

How to reproduce

-the lists are gone
-re-add the lists ==> aren't saved in the adblockplus folder (patterns.ini 0 bytes, elemhide.css 0 bytes)
-the hiding filters are useless
-I refreshed FF, reinstalled ABP, the same behaviour

Attachments (0)

Change History (8)

comment:1 Changed on 04/01/2015 at 12:11:08 PM by mapx

lib/io.js was modified (issue 1602), could be the cause ?!

comment:2 Changed on 04/01/2015 at 12:50:07 PM by mapx

  • Description modified (diff)

comment:3 Changed on 04/01/2015 at 01:33:23 PM by sebastian

  • Owner set to sebastian

comment:4 Changed on 04/01/2015 at 01:39:32 PM by sebastian

  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set
  • Summary changed from ABP 2.6.9.3928 completely broken to IO.writeToFile() doesn't support ES6 generators

Yep, this regression were introduced by moving to ES6 generators (#1602). Apparently, the new generators don't only use a different syntax, but also have a different API. You can't iterate over them using for (.. in ..) loops but have to use for (.. of ..) loops.

comment:5 Changed on 04/01/2015 at 01:41:23 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 04/01/2015 at 01:45:08 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockplus/rev/40500092bbee

comment:7 Changed on 04/01/2015 at 01:46:36 PM by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:8 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.