Opened on 04/01/2015 at 02:22:06 PM

Closed on 06/03/2015 at 03:44:42 PM

#2257 closed change (fixed)

Replace non-standard function expressions with ES6 arrow functions

Reported by: sebastian Assignee: sebastian
Priority: Unknown Milestone: Adblock-Plus-2.6.10-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: #312 Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4884233277407232

Description

Background

We currently use SpiderMonkey function shorthand syntax (e.g. function(x) x;). However, this syntax has been replaced with arrow functions (e.g. x => x) in ES6.

What to change

Replace non-standard function expressions with ES6 arrow functions.

Attachments (0)

Change History (3)

comment:1 Changed on 04/01/2015 at 02:23:29 PM by sebastian

  • Cc trev added

@trev: I already have a patch but it's up to you to set Ready and Priority.

comment:2 Changed on 04/01/2015 at 02:24:39 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 06/03/2015 at 03:44:42 PM by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.