Opened on 04/01/2015 at 03:14:14 PM
Closed on 04/29/2015 at 02:39:45 PM
#2259 closed change (fixed)
Remove non-standard JS usage from Element Hiding Helper
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Element-Hiding-Helper-1.3.3 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | trev | Blocked By: | |
| Blocking: | #312 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
We already removed non-standard JavaScript code from the adblockplus (#312) and buildtools (#1434) repositories, but there is still some non-standard code left in Element Hiding Helper.
What to change
- Replace {__proto__: null} with Object.create(null) in lib/main.js.
- Replace for each (..) with for (.. of ..) loops in lib/aardvark.js and chrome/content/composer.js.
- Replace __defineGetter__() and __defineSetter__() with Object.defineProperty() in lib/inspectorObserver.js and chrome/content/composer.js
- Replace non-standard function expressions with arrow functions.
Attachments (0)
Change History (4)
comment:1 Changed on 04/01/2015 at 03:15:31 PM by sebastian
- Cc trev added
comment:2 Changed on 04/01/2015 at 03:16:41 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 04/02/2015 at 08:15:11 PM by trev
- Priority changed from Unknown to P4
- Ready set
comment:4 Changed on 04/29/2015 at 02:39:45 PM by sebastian
- Milestone set to Element-Hiding-Helper-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
@trev: I already have a patch but it's up to you to set Ready and Priority.