Opened on 09/24/2014 at 01:01:36 PM
Closed on 12/16/2015 at 12:08:22 PM
Last modified on 12/16/2015 at 12:17:32 PM
#1434 closed defect (fixed)
Remove remaining non-standard JS usage from buildtools
| Reported by: | tschuster | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian, trev | Blocked By: | #3260, #3418, #3421 |
| Blocking: | #312 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
We already removed non-standard JavaScript code from the adblockplus repository, from prefs.js (#3418), and partly from keySelector.js (#3421) and bootstrap.js.tmpl (#3260). But there is still some non-standard code left in the buildtools repository which is bundled with Firefox extensions.
What to change
- Replace {__proto__: null} with Object.create(null) in bootstrap.js.tmpl and lib/keySelector.js.
- Replace __defineGetter__() and __defineSetter__() with Object.defineProperty() in lib/hooks.js.
- Replace __lookupGetter__() and __lookupSetter__() with Object.getOwnPropertyDescriptor() in lib/hooks.js.
Attachments (0)
Change History (20)
comment:2 Changed on 04/01/2015 at 09:10:52 AM by sebastian
- Cc sebastian trev added
- Component changed from Unknown to Build-and-Release-Tools
comment:3 Changed on 04/01/2015 at 09:17:19 AM by trev
Yes, we definitely don't want to change JSHydra, and even changing our own code there isn't worth the effort. So this sounds like a duplicate of #2013.
comment:4 Changed on 04/01/2015 at 10:06:07 AM by sebastian
- Description modified (diff)
- Ready set
I would prefer to close #2013 as duplicate of this issue, since it was filed later and only addresses a subset of these changes.
Last edited on 04/01/2015 at 10:06:20 AM
by sebastian
comment:5 Changed on 04/01/2015 at 10:06:30 AM by sebastian
- Priority changed from Unknown to P4
comment:6 Changed on 04/01/2015 at 11:35:29 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 04/01/2015 at 11:35:37 AM by sebastian
- Owner set to sebastian
comment:9 Changed on 04/01/2015 at 11:46:04 AM by sebastian
- Summary changed from Remove some non-standard JS usage from buildtools to Remove non-standard JS usage from buildtools
comment:10 Changed on 04/01/2015 at 11:51:36 AM by sebastian
- Description modified (diff)
comment:11 Changed on 04/01/2015 at 02:27:44 PM by sebastian
- Description modified (diff)
comment:12 Changed on 04/01/2015 at 03:14:49 PM by sebastian
- Description modified (diff)
comment:13 Changed on 12/16/2015 at 10:44:35 AM by sebastian
- Blocked By 3418 added
comment:14 Changed on 12/16/2015 at 10:49:03 AM by sebastian
- Description modified (diff)
- Summary changed from Remove non-standard JS usage from buildtools to Remove remaining non-standard JS usage from buildtools
- Tester set to Unknown
comment:15 Changed on 12/16/2015 at 12:07:09 PM by sebastian
- Description modified (diff)
comment:16 Changed on 12/16/2015 at 12:08:22 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:17 Changed on 12/16/2015 at 12:09:34 PM by sebastian
- Blocked By 3421 added
- Description modified (diff)
comment:18 Changed on 12/16/2015 at 12:14:19 PM by sebastian
- Blocked By 3260 added
comment:19 Changed on 12/16/2015 at 12:16:57 PM by sebastian
- Description modified (diff)
comment:20 Changed on 12/16/2015 at 12:17:32 PM by sebastian
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
I'm not sure whether we want to cleanup jshydra. As far as I know this code was forked, and doing changes like that, rebasing in the future gets just more difficult. Also jshydra depends on SpiderMonkey anyway. However, we should get rid of the non-standard code in the buildtools repository.