Opened on 04/02/2015 at 08:31:26 PM

Closed on 04/02/2015 at 10:31:39 PM

Last modified on 05/20/2015 at 02:22:39 PM

#2270 closed defect (fixed)

First run of the synchronizer unit test fails

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6247099146436608/

Description

Environment

Adblock Plus 2.6.9, Adblock Plus unit tests 1.0.1a.344

How to reproduce

  1. Start Firefox
  2. Wait 10 minutes
  3. Go to about:addons, open Adblock Plus unit tests preferences and run synchronizer unit tests.

Observed behaviour

Initial run fails, subsequent runs succeed. It seems that the internal data structures of the Synchronizer object aren't being reset for the test.

Expected behaviour

The test should always succeed

Attachments (0)

Change History (3)

comment:1 Changed on 04/02/2015 at 08:41:03 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/02/2015 at 10:31:39 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplustests/rev/c8774dc2ba8c

comment:3 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.