Opened on 04/13/2015 at 03:48:24 PM

Closed on 05/07/2015 at 11:21:39 AM

Last modified on 05/07/2015 at 11:57:17 AM

#2311 closed change (fixed)

ensure_dependencies.py should fetch and track remote Git branches when required

Reported by: kzar Assignee: kzar
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6068640302497792/

Description

Background

The ensure_dependencies.py script does not currently fetch and track remote Git branches before trying to check out the specified revision. This means that it is not easy to specify a branch name as the revision for a dependency during development. You first need to manually track the remote branch and then re-run the script.

What to change

Update the ensure_dependencies.py script in the buildtools repository so that it fetches and tracks _at least_ all the remote branches that are specified in dependency files. (Make sure that is done before attempting to check them out.)

(For some guidance Sebastian has written how this might be achieved here.)

Attachments (0)

Change History (5)

comment:1 Changed on 04/13/2015 at 03:49:09 PM by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed on 04/30/2015 at 05:33:57 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/30/2015 at 05:34:07 PM by kzar

  • Owner set to kzar

comment:4 Changed on 05/07/2015 at 11:21:39 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 05/07/2015 at 11:57:17 AM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.