Opened on 04/13/2015 at 03:36:04 PM

Closed on 04/30/2015 at 04:45:58 PM

Last modified on 05/07/2015 at 11:56:45 AM

#2310 closed change (fixed)

ensure_dependencies.py should allow both formats of Git SSH URLs

Reported by: kzar Assignee: kzar
Priority: P4 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4542760560361472/

Description

Background

GitHub and other similar services often specify the SSH URLs for repositories in a format something like git@github.com:owner/repo.git which is the equivalent of ssh://git@github.com/owner/repo.git. Currently the ensure_dependencies script will only work with URLs in the latter format.

What to change

Update the ensure_dependencies.py script in the buildtools repository so that it supports the common git@github.com:owner/repo.git format of Git SSH URLs.

(For some guidance Sebastian has written how this might be achieved here.)

Attachments (0)

Change History (5)

comment:1 Changed on 04/13/2015 at 03:37:09 PM by sebastian

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed on 04/29/2015 at 05:12:10 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/30/2015 at 04:45:58 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 04/30/2015 at 04:46:28 PM by kzar

  • Owner set to kzar

comment:5 Changed on 05/07/2015 at 11:56:45 AM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.