Opened on 04/17/2015 at 03:46:04 PM
Closed on 05/06/2015 at 07:21:16 PM
Last modified on 05/18/2015 at 01:30:04 PM
#2340 closed change (fixed)
Don't generate pages if less than 30% have been translated
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Background
Currently, we have pages like https://beta.adblockplus.org/he/about where only one string has been translated. This makes a bad impression and isn't helpful at all.
What to change
Change generation of static pages to write out pages only if at least 30% of the strings have been translated.
Attachments (0)
Change History (5)
comment:1 Changed on 04/17/2015 at 03:46:17 PM by trev
- Blocking 2035 added
comment:2 Changed on 04/17/2015 at 05:18:44 PM by trev
- Owner set to trev
comment:3 Changed on 04/17/2015 at 05:24:17 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 05/06/2015 at 07:21:16 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 05/18/2015 at 01:30:04 PM by Ross
- Verified working set
Implemented and working.
Tested by:
Creating a test CMS content project containing an index file and one localised page with 20 translatable strings. The localised page is generated if 6 or more (30%) strings are in the matching locale file and is not generated with 5 or less.
Tested with:
cms / r43
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/cms/rev/e7b75ccc5e12