Opened on 04/20/2015 at 03:26:29 PM

Closed on 07/16/2015 at 12:50:45 PM

#2357 closed change (fixed)

Implement "Add predefined list" dialog

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By: #1524
Blocking: #2355, #2410 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29321417/

Description

Background

Clicking on "abp:subscribe" links opens the options page and asks for confirmation from the user. This requires a more restricted version of the "Add further blocking list" dialog to be added.

What to change

  • Implement separate dialog based on design mockup similar to existing "Add further blocking list" dialog
  • The dialog should be created based on the provided filter list title and URL
  • Don't show the filter list title if it's not specified
  • Clicking on the "Yes, use this filter list" button should add the filter list
  • Click on "cancel" should simply close the dialog

Attachments (0)

Change History (5)

comment:1 Changed on 04/23/2015 at 02:04:02 PM by greiner

  • Blocked By 1524 added

comment:2 Changed on 07/03/2015 at 08:48:03 AM by greiner

  • Blocking 2410 added

comment:3 Changed on 07/03/2015 at 08:56:15 AM by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:4 Changed on 07/03/2015 at 04:09:16 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 07/16/2015 at 12:50:45 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
 
Note: See TracTickets for help on using tickets.