Opened on 04/23/2015 at 12:23:19 PM

Closed on 10/02/2015 at 03:01:45 PM

#2410 closed change (fixed)

Make dialogs on new options page more accessible

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords: a11y
Cc: Blocked By: #1524, #2357
Blocking: #2407 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29323156/

Description

Background

In the current version of the new options page (see #1524) interaction with dialogs is only possible using the cursor. Therefore we should implement standardized techniques to support screen readers and enable keyboard interactions.

What to change

  • Mark dialogs as such using the following ARIA attributes:
    • role="dialog"
    • aria-labelledby
    • aria-hidden="true"
  • Move the focus to the default action of the dialog (e.g. "OK" button) when the dialog becomes visible
  • Make sure there's always at least one focusable element inside of any dialog
  • Update the aria-hidden attribute each time the visibility of a dialog changes
  • Preferably, the tab order should be contained by the dialog to prevent that a focusable element outside of the dialog receives focus

Attachments (0)

Change History (5)

comment:1 Changed on 04/23/2015 at 02:04:02 PM by greiner

  • Blocked By 1524 added

comment:2 Changed on 07/03/2015 at 08:48:03 AM by greiner

  • Blocked By 2357 added
  • Tester set to Unknown

comment:3 Changed on 07/03/2015 at 08:56:29 AM by greiner

  • Owner set to greiner

comment:4 Changed on 07/31/2015 at 03:08:48 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 10/02/2015 at 03:01:45 PM by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
 
Note: See TracTickets for help on using tickets.