Opened on 04/20/2015 at 03:50:24 PM

Closed on 08/29/2019 at 05:43:52 PM

#2360 closed change (rejected)

[meta] Add ability to hide elements by their child elements

Reported by: Lain_13 Assignee: hfiguiere
Priority: P2 Milestone:
Module: Core Keywords: meta, filtersyntax, closed-in-favor-of-gitlab
Cc: mapx, greiner, sebastian, fhd, arthur Blocked By: #3142, #3143
Blocking: #4118 Platform: Unknown
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

Sometimes it is not possible to properly hide an ad unit because they are (almost) indistinguishable from similar organic content on the page. For example, it could be a paid post with advertisement link in the blog or ads in the search results (like ads on Yandex which were impossible to hide with adblock for a while and recently became selectable again simply by mistake). The general problem is the same since there is no way to target that block. It's only possible to hide something inside of it and often that is far from being enough to even get rid of the advertisement.

There are two proposals and one doesn't necessarily exclude another so both could be implemented.

  1. Add support for XPath (see #3142)
  2. Add support for the proposed CSS4 pseudo-selector :has() (see #3143)

Attachments (0)

Change History (13)

comment:1 Changed on 04/20/2015 at 04:33:10 PM by mapx

  • Cc mapx greiner added

comment:2 Changed on 04/28/2015 at 10:07:52 AM by sebastian

  • Cc sebastian added

comment:3 Changed on 09/30/2015 at 11:49:28 AM by greiner

  • Blocked By 3142, 3143 added
  • Component changed from Unknown to Core
  • Description modified (diff)
  • Keywords meta filtersyntax added
  • Summary changed from Support XPath or at least :has() pseudo-selector to hide parent by it's child to [meta] Add ability to hide elements by their child elements
  • Tester set to Unknown

Split this ticket up into one for XPath support (#3142) and one for the CSS4 polyfill (#3143).

comment:4 Changed on 06/17/2016 at 03:28:27 PM by fhd

  • Cc fhd added

comment:5 Changed on 06/17/2016 at 03:32:45 PM by fhd

  • Blocking 4118 added

comment:6 Changed on 06/17/2016 at 03:37:44 PM by fhd

  • Owner set to fhd

I'll look into this, most likely via #3143.

comment:7 Changed on 06/17/2016 at 03:46:16 PM by fhd

  • Priority changed from Unknown to P2

comment:8 Changed on 06/29/2016 at 01:49:16 PM by Lain_13

Last edited on 08/05/2016 at 12:12:30 PM by Lain_13

comment:9 Changed on 08/11/2016 at 07:56:22 AM by mapx

well, with the FB battle, many users are waiting for this implementation
https://adblockplus.org/forum/viewtopic.php?f=1&t=48064

comment:10 in reply to: ↑ description Changed on 09/17/2016 at 10:57:09 PM by bopoh13

Replying to Lain_13:

I've a dirty patch for this: ​https://greasyfork.org/en/scripts/14720-it-s-not-important

How to use your scripts?
UPD: Sorry, I realized after reading the link the message.

Last edited on 09/17/2016 at 11:11:55 PM by bopoh13

comment:11 Changed on 12/19/2016 at 02:54:58 PM by arthur

  • Cc arthur added

comment:12 Changed on 05/29/2017 at 11:45:27 AM by fhd

  • Owner changed from fhd to hfiguiere

comment:13 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
 
Note: See TracTickets for help on using tickets.