Opened on 09/30/2015 at 11:26:53 AM

Closed on 08/29/2019 at 05:43:52 PM

Last modified on 10/08/2019 at 05:43:39 PM

#3142 closed change (rejected)

Add XPath capabilities to element hiding filters

Reported by: greiner Assignee:
Priority: P5 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: ubernitt, Lain_13, mapx, sergz, erikvold Blocked By: #2388
Blocking: #2360 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

(taken from original description in #2360 about hiding elements by selecting their child elements)

In general XPath is a generic solution for various problems such as selecting an element depending on its children. But XPath filters have similar issues as CSS property filters such as requiring to hide elements manually and to observe the page for changes at runtime. Therefore waiting for #2388 to be closed probably makes the most sense to get the necessary architecture in place first.

See forum post

What to change

  • Allow XPath notation in element hiding filters in a backwards-compatible fashion
  • Disallow generic XPath filters to avoid performance issues
  • Select and hide elements in the content script using document.evaluate()

Attachments (0)

Change History (9)

comment:1 Changed on 09/30/2015 at 11:49:28 AM by greiner

  • Blocking 2360 added

comment:2 Changed on 09/30/2015 at 12:03:24 PM by mapx

  • Cc Lain_13 mapx added

comment:3 Changed on 06/17/2016 at 03:45:49 PM by fhd

  • Priority changed from Unknown to P5

I think we should try #3143 first, since it'd just be a polyfill for something that'll be possible with vanilla CSS in the near future. So I'm making this one a P5. If it's interesting for reasons beyond solving #2360, feel free to elaborate.

comment:4 Changed on 01/10/2017 at 11:09:59 AM by 0acceptable

the functions: matches(), replace() and tokenize() , have inbuilt support for Regular Expressions in XPath 2.0

Will adb support this?

comment:5 Changed on 03/24/2017 at 11:40:40 AM by sergz

  • Cc sergz added

comment:6 Changed on 11/15/2018 at 05:14:20 AM by erikvold

  • Cc erikvold added

comment:7 Changed on 04/18/2019 at 11:51:22 AM by ubernitt

  • Cc ubernitt added

comment:8 Changed on 05/21/2019 at 11:25:21 AM by ashwink

spam

Last edited on 10/08/2019 at 05:43:39 PM by kzar

comment:9 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.