Opened on 04/21/2015 at 10:06:30 AM
Closed on 08/02/2017 at 04:31:37 PM
#2373 closed change (fixed)
Add/change a sentence on filters page regarding EHH removing tag names by default
| Reported by: | arthur | Assignee: | ire |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | trev, saroyanm | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
On https://adblockplus.org/en/filters#elemhide examples are shown with e. g. ##div#sponsorad and ##div.textad. Element Hiding Helper removes the tag names (-> ###sponsorad and ##.textad) because ABP processes them faster.
What to change
Change the text as to not suggest using tag names in selectors - this is an artifact from the simplified syntax which we no longer support.
The first advertisement above is contained inside an element with class attribute "textad". The following rule will hide exactly any such element: ##.textad. Here ## marks an element hiding rule while the rest is a selector identifying the elements that need to be hidden. You can hide elements by their id attribute similarly, ###sponsorad will hide the second advertisement. And you can hide elements by element name only, e.g. ##textad for the third advertisement.
We should also remove tag names (and *) from the example selectors in the following sections. And to the first paragraph under "Advanced selectors" we should add:
Please keep in mind that browsers are slower to process these selectors than selectors based on class or id attribute only.
Attachments (0)
Change History (9)
comment:1 Changed on 06/01/2015 at 10:00:05 AM by saroyanm
- Cc trev added
comment:2 Changed on 06/01/2015 at 10:07:39 AM by saroyanm
- Cc saroyanm added
comment:3 Changed on 10/07/2016 at 09:14:19 AM by trev
- Description modified (diff)
- Tester set to Unknown
comment:4 Changed on 11/28/2016 at 01:50:16 PM by saroyanm
- Priority changed from Unknown to P3
- Ready set
This looks to be ready.
comment:5 Changed on 01/25/2017 at 03:23:11 PM by juliandoucette
- Keywords goodfirstbug added
comment:6 Changed on 07/31/2017 at 10:07:09 AM by ire
- Owner set to ire
comment:7 Changed on 08/01/2017 at 01:37:45 PM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 08/02/2017 at 04:29:49 PM by abpbot
A commit referencing this issue has landed:
Issue 2373 - Add/change a sentence on filters page regarding EHH removing tag names by default
comment:9 Changed on 08/02/2017 at 04:31:37 PM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
IMO it's better to use second option, because it makes more sense I'm not sure why it was specified like that initially.
Wladimir can you please let me know if there was a reason of using rule like ##*#sponsorad in the documentation ? I think the second suggestion is more reasonable and we can go with the second one.
I don't think this ticket has anything to do with EHH.