Opened on 04/21/2015 at 10:08:56 AM
Closed on 03/18/2016 at 11:12:10 AM
#2374 closed change (fixed)
Implement "Tweaks" section in new options page
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | 2016q1 |
| Cc: | sebastian, kzar | Blocked By: | #1524, #2356 |
| Blocking: | #2372, #3800 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
In the current version of the options page we expose some general settings in the General tab. Those settings should be exposed under "Tweaks".
What to change
- Implement the "Show right-click menu Block Element" setting as a checkbox in the Tweaks section (as outlined in the provided design mockup)
- Clicking on the checkbox should toggle the shouldShowBlockElementMenu preference like it does in the current version of the options page
- Implement the "Show useful notifications" setting as a checkbox in the Tweaks section (see #2195)
- This setting should be hidden by default and only be shown if Prefs.notifications_showui is set to true
- Clicking on the checkbox should toggle the "*" entry in Prefs.notifications_ignoredcategories
- Checkboxes should be kept up-to-date using prefs.listen
- Add prefs.toggle message type to messageResponder.js
- Add an option to enable experimental content blocker mode on Safari as specified in #3687.
- Add an option to remove the devtools panel as specified in #3796.
Attachments (0)
Change History (13)
comment:1 Changed on 04/23/2015 at 02:04:02 PM by greiner
- Blocked By 1524 added
comment:2 Changed on 04/27/2015 at 05:34:12 PM by greiner
- Blocked By 2356 added
comment:3 Changed on 11/09/2015 at 03:10:15 PM by mario
- Keywords 2015q4 added
- Tester set to Unknown
comment:5 Changed on 01/06/2016 at 02:57:30 PM by greiner
- Description modified (diff)
- Ready set
The tooltips for individual settings will be added later on.
comment:6 Changed on 01/06/2016 at 05:36:27 PM by greiner
- Owner set to greiner
comment:7 Changed on 01/25/2016 at 03:58:28 PM by sebastian
- Cc sebastian added
- Keywords 2016q1 added; 2015q4 removed
comment:8 Changed on 02/24/2016 at 05:11:28 PM by sebastian
- Cc kzar added
- Description modified (diff)
comment:9 Changed on 02/25/2016 at 05:56:45 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:10 Changed on 03/14/2016 at 01:56:51 PM by sebastian
- Description modified (diff)
comment:11 Changed on 03/14/2016 at 08:16:49 PM by sebastian
- Blocking 3800 added
comment:12 Changed on 03/18/2016 at 11:11:26 AM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/0ccb42e76177
comment:13 Changed on 03/18/2016 at 11:12:10 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Updated ticket to reflect changes to existing options page in #2195.