Opened on 04/21/2015 at 01:52:55 PM
Closed on 09/24/2015 at 09:39:45 AM
#2381 closed change (fixed)
Implement share overlay in new options page
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | #1524 | |
| Blocking: | #2380 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
In the first-run page we show an overlay containing different sharing options if someone clicks on one of the share buttons. We also want to have this overlay in the new options page.
What to change
- Check if one of the resources required for showing the social media buttons in the overlay is blocked (same check we already use in the first-run page)
- If one or more of the resources are blocked: Hide the share button in the sidebar
- If none of the resources is blocked: Attach a click-listener to the share button in the sidebar which opens the overlay (same way we do in the first-run page)
- The share button should always be hidden for users with a Chinese locale
Notes for dependency update
This change moves the code that's shared between first-run page and options page into common.js and skin/common.css. Therefore these two files are required for either of those pages to work properly.
Attachments (0)
Change History (5)
comment:1 Changed on 04/23/2015 at 02:04:02 PM by greiner
- Blocked By 1524 added
comment:2 Changed on 07/02/2015 at 03:27:48 PM by greiner
- Owner set to greiner
- Tester set to Unknown
comment:3 Changed on 07/02/2015 at 03:28:03 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 09/24/2015 at 09:39:45 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockplusui/rev/f8e3e591fcbb