Opened on 04/21/2015 at 01:54:36 PM

Closed on 04/23/2015 at 12:48:23 AM

Last modified on 04/23/2015 at 02:07:13 PM

#2382 closed defect (fixed)

[kick.py] Remove hard-coded Puppet-master in updateMaster()

Reported by: matze Assignee: matze
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: fred, trev, fhd Blocked By: #2379
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6009686776086528

Description

The kick.py script contains a hard-coded reference to puppetmaster.adblockplus.org, although we've introduced the --remote parameter to specify a master explicitly.

Attachments (0)

Change History (4)

comment:1 Changed on 04/21/2015 at 01:56:42 PM by matze

  • Cc trev fhd added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/23/2015 at 12:48:23 AM by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/infrastructure/rev/e15f85b2f80f

comment:3 Changed on 04/23/2015 at 02:04:02 PM by greiner

  • Blocked By 1524 added

comment:4 Changed on 04/23/2015 at 02:07:13 PM by greiner

  • Blocked By 1524 removed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from matze.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.