Opened on 04/22/2015 at 12:07:25 PM
Closed on 11/30/2015 at 03:25:35 PM
#2392 closed change (fixed)
Create a container for CSS property filters
| Reported by: | trev | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | #2390 | |
| Blocking: | #2389, #2393, #2396 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
The new filter class introduced in #2390 needs its own container with appropriate API.
What to change
Add cssRules.js module defining a CSSRules singleton. It should have the following methods:
- add(filter)
- remove(filter)
- clear()
- getRulesForDomain()
It should use appropriate data structures to make sure that getRulesForDomain() is efficient.
Attachments (0)
Change History (8)
comment:1 Changed on 04/22/2015 at 12:10:35 PM by trev
- Blocking 2393 added
comment:2 Changed on 04/22/2015 at 12:13:41 PM by trev
- Blocked By 2390 added
comment:3 Changed on 04/22/2015 at 12:48:05 PM by trev
- Blocking 2396 added
comment:4 Changed on 04/27/2015 at 04:43:07 PM by greiner
- Blocked By 235 added
comment:5 Changed on 07/31/2015 at 04:39:00 PM by greiner
- Owner set to greiner
- Tester set to Unknown
comment:6 Changed on 08/25/2015 at 04:12:04 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 11/30/2015 at 03:24:33 PM by greiner
- Blocked By 235 removed
comment:8 Changed on 11/30/2015 at 03:25:35 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I'd really like to finish ticket #235 before starting with this one to avoid discussing and working on the same approach in two different places since those two changes implement similar functionality.