Opened on 04/22/2015 at 12:10:35 PM

Closed on 11/30/2015 at 03:26:11 PM

#2393 closed change (fixed)

Make filter listener consider CSS property filters

Reported by: trev Assignee: greiner
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By: #2392
Blocking: #2389 Platform: Unknown
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29324599/

Description (last modified by greiner)

Background

In #2392 we implement a new container class for CSS property filters. We need to make sure that these filters are actually added to it.

What to change

Change FilterListener implementation to distinguish between element hiding rules and CSS property filters. The latter should be added to the new CSSRules container.

Notes for dependency update

This change requires lib/cssRules.js to be added for lib/filterListener.js to work.

Attachments (0)

Change History (3)

comment:1 Changed on 08/04/2015 at 01:45:41 PM by greiner

  • Owner set to greiner
  • Tester set to Unknown

comment:2 Changed on 08/25/2015 at 04:12:15 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 11/30/2015 at 03:26:11 PM by greiner

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockplus/rev/d85bc9354210

Also added a note for dependency updates.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.