Opened on 03/11/2014 at 10:38:46 AM
Closed on 06/02/2014 at 09:28:24 AM
Last modified on 07/15/2014 at 05:01:18 PM
#24 closed change (fixed)
[libadblockplus integration cleanup] Use Matcher.find() instead of Matcher.matches()
Reported by: | fhd | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | Adblock-Plus-for-Android-1.3 |
Module: | Adblock-Plus-for-Android | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #7 | Platform: | Android |
Ready: | no | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description
Background
See #7.
What to change
Use Matcher.find() instead of Matcher.matches() (http://codereview.adblockplus.org/11172036/diff/1/src/org/adblockplus/android/AdblockPlus.java#newcode56)
Attachments (0)
Change History (13)
comment:1 Changed on 03/11/2014 at 10:51:58 AM by philll
- Blocking 7 added
comment:2 Changed on 03/11/2014 at 12:57:59 PM by philll
- Keywords libadblockplus integration cleanup removed
comment:3 Changed on 03/11/2014 at 09:34:51 PM by trev
- Component changed from Unknown to ABP-Android
comment:4 Changed on 03/12/2014 at 11:38:19 AM by philll
- Owner set to rjeschke
- Status changed from new to assigned
comment:5 Changed on 03/12/2014 at 04:55:19 PM by fhd
- Priority changed from Unknown to P3
comment:6 Changed on 03/12/2014 at 05:05:49 PM by fhd
- Reporter changed from philll to fhd
comment:7 Changed on 03/12/2014 at 05:12:33 PM by fhd
- Owner rjeschke deleted
comment:8 Changed on 03/12/2014 at 05:12:56 PM by fhd
- Status changed from assigned to accepted
comment:9 Changed on 03/21/2014 at 09:11:02 AM by philll
- Status changed from accepted to new
comment:10 Changed on 06/02/2014 at 09:19:22 AM by rjeschke
- Ready unset
comment:11 Changed on 06/02/2014 at 09:28:24 AM by rjeschke
- Resolution set to fixed
- Status changed from new to closed
comment:12 Changed on 06/02/2014 at 11:49:46 AM by philll
- Review URL(s) modified (diff)
comment:13 Changed on 07/15/2014 at 05:01:18 PM by trev
- Milestone set to Adblock-Plus-for-Android-1.3
- Platform set to Android
Note: See
TracTickets for help on using
tickets.
In progress: http://codereview.adblockplus.org/6298415575072768/