Opened on 05/05/2015 at 09:17:10 PM
Closed on 05/06/2015 at 04:46:16 PM
Last modified on 05/15/2015 at 03:49:39 AM
#2460 closed change (fixed)
[cms] Support <span> tags inside translatable strings
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | yes | |
| Review URL(s): | |||
Description
Background
On https://beta.adblockplus.org/en/customize-facebook the text "Customize Facebook with Adblock Plus" is currently broken up into multiple translatable strings because "Facebook" is inside a <span> tag.
What to change
Allow <span> inside translatable strings.
Attachments (0)
Change History (3)
comment:1 Changed on 05/05/2015 at 09:28:44 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 05/06/2015 at 04:46:16 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 05/15/2015 at 03:49:39 AM by Ross
- Verified working set
Fixed.
Tested by:
Adding an example string with <span> tags to a CMS page and checking the output.
Sidenote:
https://beta.adblockplus.org/en/customize-facebook does not seem to exist any more. Is that correct?
cms / r42
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/cms/rev/45be83c7cf11