Opened on 05/06/2015 at 07:47:51 AM
Closed on 05/28/2015 at 02:09:05 PM
Last modified on 06/30/2015 at 09:33:59 AM
#2461 closed change (fixed)
Move our custom strings out of strings.xml.in
| Reported by: | fhd | Assignee: | Mailkov |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-beta-1.0.0.2015081632 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
https://bitbucket.org/adblockplus/adblockbrowser/pull-request/1 |
||
Description
Background
We're currently storing a bunch of strings in strings.xml.in. We're just supposed to reference strings from android_strings.dtd there, however.
What to change
Move all of our custom strings from strings.xml.in to android_strings.dtd and only refer to them by key in strings.xml.in - the same way all the upstream strings do it.
Attachments (0)
Change History (10)
comment:1 Changed on 05/20/2015 at 09:00:48 AM by fhd
- Sensitive unset
comment:2 Changed on 05/22/2015 at 09:44:50 AM by Mailkov
comment:3 follow-up: ↓ 4 Changed on 05/22/2015 at 09:46:27 AM by fhd
- Owner set to Mailkov
Sure, done!
Could you do a pull request on BitBucket with this when you're done? We don't have a GitHub mirror for this one.
comment:4 in reply to: ↑ 3 Changed on 05/22/2015 at 10:00:16 AM by Mailkov
Replying to fhd:
Sure, done!
Could you do a pull request on BitBucket with this when you're done? We don't have a GitHub mirror for this one.
Sure, there is no problem.
comment:5 Changed on 05/26/2015 at 09:58:34 AM by Mailkov
I want advice you that I completed this issue but I have some problems to make the pull request.
comment:6 Changed on 05/28/2015 at 07:56:38 AM by Mailkov
comment:7 Changed on 05/28/2015 at 08:05:23 AM by fhd
- Status changed from new to reviewing
comment:9 Changed on 05/28/2015 at 02:09:05 PM by fhd
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 06/30/2015 at 09:33:59 AM by philll
- Platform changed from Android to Adblock Browser for Android
See #2673
I would like to work on this... Can you assign it to me?