Opened on 05/08/2015 at 08:54:49 AM

Closed on 05/08/2015 at 04:21:26 PM

Last modified on 06/30/2015 at 09:33:59 AM

#2475 closed defect (fixed)

Developer tools settings show up on tablets

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5424478255316992/

Description (last modified by fhd)

Environment

Adblock Browser for Android revision 989a6e356d4a on a Nexus 9 running Android 5.0.2. This issue only appears on tablets.

How to reproduce

  1. Open the settings (from the hamburger menu)

Observed behaviour

There's an item called Developer tools on the left side.

Expected behaviour

There shouldn't be an entry called Developer tools (see #2353).

Attachments (0)

Change History (9)

comment:1 Changed on 05/08/2015 at 08:55:14 AM by fhd

  • Description modified (diff)

comment:2 Changed on 05/08/2015 at 08:56:02 AM by fhd

  • Description modified (diff)

comment:3 Changed on 05/08/2015 at 09:25:28 AM by fhd

Pretty sure this is a regression introduced by our upstream merge (#2352).

comment:4 Changed on 05/08/2015 at 02:57:42 PM by fhd

  • Owner set to fhd

comment:5 Changed on 05/08/2015 at 03:05:30 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 05/08/2015 at 04:21:26 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:8 Changed on 05/26/2015 at 03:18:25 PM by fhd

Was pushed as: ​https://bitbucket.org/adblockplus/adblockbrowser/commits/0ee7405a30d3

comment:9 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.