Opened on 05/08/2015 at 08:59:03 AM

Closed on 05/08/2015 at 04:21:32 PM

Last modified on 06/30/2015 at 09:33:59 AM

#2476 closed defect (fixed)

The Adblock Browser settings item says Eyeo

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5223816309506048/

Description

Environment

Adblock Browser for Android revision 989a6e356d4a on a Nexus 9 running Android 5.0.2. This issue only appears on tablets.

How to reproduce

  1. Open the settings (from the hamburger menu)

Observed behaviour

There's an item called Eyeo on the left side.

Expected behaviour

The Eyeo item should be called Adblock Browser (see #2354).

Attachments (0)

Change History (10)

comment:1 Changed on 05/08/2015 at 08:59:13 AM by fhd

  • Sensitive set

comment:2 Changed on 05/08/2015 at 08:59:42 AM by fhd

  • Component changed from Unknown to Flux
  • Milestone set to Flux-next
  • Platform changed from Unknown to Android
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed on 05/08/2015 at 09:00:07 AM by fhd

  • Summary changed from The ''Adblock Browser'' settings item says ''Eyeo'' to The Adblock Browser settings item says Eyeo

comment:4 Changed on 05/08/2015 at 09:25:50 AM by fhd

Pretty sure this is a regression introduced by our upstream merge (#2352).

comment:5 Changed on 05/08/2015 at 03:01:05 PM by fhd

  • Owner set to fhd

comment:6 Changed on 05/08/2015 at 03:13:00 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 05/08/2015 at 04:21:32 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:9 Changed on 05/26/2015 at 03:19:02 PM by fhd

Was pushed as: ​https://bitbucket.org/adblockplus/adblockbrowser/commits/f5441b4603d4

comment:10 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.