Opened on 05/08/2015 at 01:54:59 PM
Closed on 05/08/2015 at 08:01:33 PM
Last modified on 06/30/2015 at 09:33:59 AM
#2482 closed defect (fixed)
An update is found even when on the latest version
| Reported by: | fhd | Assignee: | fhd |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-beta-1.0.0.2015052021 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by fhd)
Environment
Adblock Browser for Android 1.0.0.20150508144955 on a Nexus 9 running Android 5.0.2.
How to reproduce
- Ensure you're on the latest version (currently that's the one above)
- Open the about page by entering about: in the URL bar
- Touch Check for Updates
Observed behaviour
An update is found and will be downloaded.
Expected behaviour
No update should be found - we're already on the latest version after all.
Attachments (0)
Change History (8)
comment:1 Changed on 05/08/2015 at 01:57:03 PM by fhd
Last edited on 05/08/2015 at 02:00:53 PM
by fhd
comment:2 Changed on 05/08/2015 at 01:58:26 PM by fhd
- Summary changed from Update checks seem to detect an update when on the latest version to An update is found even when on the latest version
comment:4 Changed on 05/08/2015 at 08:01:33 PM by fhd
- Resolution set to fixed
- Status changed from new to closed
Turns out the build number is fine if you do a clobber, i.e. full rebuild. Relatively annoying, but it's better than to mess around with the build system.
comment:5 Changed on 05/11/2015 at 11:42:28 AM by fhd
- Owner set to fhd
comment:6 Changed on 05/11/2015 at 11:43:17 AM by fhd
- Milestone set to Flux-next
comment:7 Changed on 05/20/2015 at 09:00:48 AM by fhd
- Sensitive unset
Note: See
TracTickets for help on using
tickets.
I've found that AppConstants.MOZ_APP_BUILDID (in obj-*/mobile/android/base/generated/preprocessed/org/mozilla/gecko/AppConstants.java) differs from the actual build ID under obj-*/config/buildid. The former ID is used in the Android layer, the latter in the Gecko layer.
It looks like the issue is that the build process is generating AppConstants.java before updating the build ID. Most certainly an upstream issue, Mozilla probably didn't notice it so far.