Opened on 05/08/2015 at 08:55:36 PM
Closed on 05/18/2015 at 07:55:07 PM
Last modified on 06/30/2015 at 09:33:59 AM
#2483 closed change (fixed)
Give Adblock Browser its own app ID
| Reported by: | fhd | Assignee: | fhd |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-beta-1.0.0.2015052021 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Kirill | Blocked By: | |
| Blocking: | #2520 | Platform: | Adblock Browser for Android |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by fhd)
Background
Adblock Browser needs its own app ID - it currently has the same one as Firefox for Android.
What to change
Change the app ID of Adblock Browser to 55aba3ac-94d3-41a8-9e25-5c21fe874539.
Attachments (0)
Change History (17)
comment:1 Changed on 05/08/2015 at 09:03:04 PM by fhd
comment:2 Changed on 05/08/2015 at 09:04:47 PM by fhd
I think the cleanest approach would be to change the app ID indeed. We need to make some changes to ABP upstream, and we can't really do that before announcing the browser - that's the downside. However, we could commit a patch for that and apply it at build time for now. Once we release, we can just merge this patch upstream.
comment:3 Changed on 05/11/2015 at 09:32:32 AM by fhd
- Owner set to fhd
comment:4 Changed on 05/12/2015 at 08:24:41 PM by fhd
- Description modified (diff)
- Summary changed from Download requests are indistinguishable from ABP for Firefox requests to Give Adblock Browser a unique app ID
- Type changed from defect to change
Yeah, we definitely want to change the app ID - turning this into a change.
comment:5 Changed on 05/12/2015 at 08:39:59 PM by fhd
- Blocked By 2509, 2510 added
- Description modified (diff)
comment:6 Changed on 05/12/2015 at 09:19:09 PM by fhd
- Summary changed from Give Adblock Browser a unique app ID to Give Adblock Browser its own app ID
comment:7 Changed on 05/13/2015 at 08:13:28 PM by fhd
- Blocked By 2509 removed
comment:8 Changed on 05/13/2015 at 08:15:08 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 05/13/2015 at 08:40:19 PM by fhd
- Review URL(s) modified (diff)
- Status changed from reviewing to reopened
comment:10 Changed on 05/14/2015 at 03:25:08 PM by fhd
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:11 Changed on 05/14/2015 at 03:26:00 PM by fhd
- Description modified (diff)
Filed #2520 for enabling extension compatibility checking again.
comment:12 Changed on 05/14/2015 at 03:28:38 PM by fhd
- Blocking 2520 added
comment:13 Changed on 05/18/2015 at 12:04:40 PM by Kirill
- Cc Kirill added
comment:14 Changed on 05/18/2015 at 07:55:07 PM by fhd
- Blocked By 2510 removed
- Resolution set to fixed
- Status changed from reviewing to closed
comment:15 Changed on 05/20/2015 at 09:00:48 AM by fhd
- Sensitive unset
comment:16 Changed on 05/26/2015 at 03:26:36 PM by fhd
comment:17 Changed on 06/30/2015 at 09:33:59 AM by philll
- Platform changed from Android to Adblock Browser for Android
See #2673
We're currently using fennec2 as our app ID, looks like we'll have to change this one way or another.
If we change the app ID, ABP won't work anymore - it's hard coding fennec2 in a few places. If we do change the app ID, we can back out the commit that disabled compatibility checking.
The alternative would be to monkey patch downloader.js, which may be a bit less effort.