Opened on 05/13/2015 at 08:01:17 AM
Closed on 12/28/2016 at 03:14:01 PM
Last modified on 06/19/2017 at 07:53:16 AM
#2513 closed change (fixed)
Adblock Browser does not display chosen filter lists as active right away
| Reported by: | philll | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P5 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | fhd, sven | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | no | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Asus Nexus 7
Android 5.1.1
Adblock Browser 1.0.0.20150508204826
How to reproduce
- Tap the three dot menu
- Tap Settings
- Tap Adblocking
- Tap Adblocking
- Unselect all lists shown under the "Active for websites in" section
- Go back to the previous menu
- Tap the Adblocking menu (Configure your filter subscriptions) again
- Select any list from below
Observed behaviour
The checkbox at the selected list is checked but the "Active for websites in" section stays empty.
Expected behaviour
All offered filter lists should always be shown in the "Other languages" section (I wonder, whether that is an appropriate naming, as it already assumes that there is a choice active) and if selected, also in the "Active for websites in" section right away. If a list is deselected, it should be removed from that section right away and unchecked in the "Other languages" section.
Attachments (0)
Change History (16)
comment:1 Changed on 05/13/2015 at 08:13:34 AM by fhd
- Cc sven added
- Platform changed from Firefox/Firefox Mobile to Android
comment:2 Changed on 05/13/2015 at 08:35:47 AM by philll
As I wrote in the expected behaviour section, I don't expect it to "jump up" and thus disappear from the area that I am viewing and rather be displayed on top additionally.
comment:3 Changed on 05/13/2015 at 08:39:43 AM by fhd
Sorry, missed that. Yeah that'd avoid the jumping, but is duplicate better?
I've checked how it works in iOS, and there we actually have this jumping behaviour - is that by design though?
comment:4 Changed on 05/13/2015 at 10:37:30 AM by sven
To keep this issue updated: only fhd saw this behavior in iOS, because of his screen-sharing meeting. I didn't specified that behavior, but i would like to see their implementation first to decide whether this approach makes sense or not.
comment:5 Changed on 05/13/2015 at 12:12:02 PM by philll
@fhd: I wonder where you looked at at iOS? I only see one huge list of subsriptions that get an additional check arrow one you tap them, no different section where something could jump to?
comment:6 Changed on 05/18/2015 at 12:08:51 PM by rjeschke
Keep in mind, that we are on Android. Copying iOS behaviour is the wrong way to do UX on Android.
Android has it's own style guides, look and feel, ... so please refrain from trying to build an iOS app on Android.
Also: having two different lists is complicated enough (and also not often seen on Android), so we really should avoid causing any more confusion (for users and developers) by duplicating entries or jumping around.
comment:7 Changed on 05/18/2015 at 02:01:25 PM by sven
Keep in mind, that we are on Android. Copying iOS behaviour is the wrong way to do UX on Android.
Android has it's own style guides, look and feel, ... so please refrain from trying to build an iOS app on Android.
Don't worry. I'm aware of that and consider that :-)
comment:8 Changed on 05/20/2015 at 09:00:48 AM by fhd
- Sensitive unset
comment:9 Changed on 05/21/2015 at 02:45:56 PM by rjeschke
- Priority changed from Unknown to P3
- Type changed from defect to change
comment:10 Changed on 06/30/2015 at 09:33:59 AM by philll
- Platform changed from Android to Adblock Browser for Android
See #2673
comment:11 Changed on 10/01/2015 at 05:23:45 PM by fhd
- Priority changed from P3 to P5
- Tester set to Unknown
So, based on the discussion here, we probably don't actually want that. Setting to P5.
comment:12 Changed on 05/31/2016 at 10:21:58 AM by diegocarloslima
- Owner set to diegocarloslima
comment:13 Changed on 05/31/2016 at 10:22:50 AM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:14 Changed on 12/28/2016 at 03:12:29 PM by abpbot
A commit referencing this issue has landed:
Issue 2513 - Adblock Browser does not display chosen filter lists as active right away
comment:15 Changed on 12/28/2016 at 03:14:01 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:16 Changed on 06/19/2017 at 07:53:16 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- When following the steps above, the selected filter list no longer stays newly selected in the 'other languages', but is actively moved to the 'Active for websites in...' section after selection.
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
As far as I'm concerned the behaviour makes sense this way - it's hard for the user to undo adding/removing a language if it jumps far up or down the screen right after they toggle it. But there's on situation in which I could see this as misleading: When there are no lists enabled and you add one. Then it says None under Active for websites in, even though some lists are active.
What do you think, Sven?