Opened on 05/13/2015 at 07:32:59 AM
Closed on 10/17/2016 at 06:06:15 PM
Last modified on 06/19/2017 at 07:50:06 AM
#2512 closed defect (fixed)
A square to mark and unmark is displayed on the side of "None".
| Reported by: | passbrains | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | sven | Blocked By: | #3820 |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by fhd)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ADR-4
Environment
Samsung + Galaxy S3 + Android 4.3
How to reproduce
- Install the browser.
- Go to Settings -> Adblocking -> Adblocking
- Click on the filter list which was selected to make selection empty.
- Go back. Click on Adblocking.
Observed behaviour
A square is displayed on the side of "None".
Expected behaviour
"None" is displayed without any square on the side of it.
Attachments (1)
Change History (14)
Changed on 05/13/2015 at 07:33:04 AM by passbrains
comment:1 Changed on 05/13/2015 at 07:38:59 AM by fhd
- Component changed from Unknown to Flux
- Description modified (diff)
- Platform changed from Firefox/Firefox Mobile to Android
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 05/13/2015 at 07:42:27 AM by fhd
- Cc sven added
- Ready unset
Let's hear Sven's opinion first actually :)
comment:3 Changed on 05/13/2015 at 08:58:18 AM by sven
I agree, there shouldn't be a check-box.
comment:4 Changed on 05/18/2015 at 12:13:32 PM by rjeschke
I really do not understand the problem here, as the entry is disabled. Still, will try to come up with some custom UI element to put there in replacement.
comment:5 Changed on 05/20/2015 at 09:00:48 AM by fhd
- Sensitive unset
comment:6 Changed on 06/30/2015 at 09:33:59 AM by philll
- Platform changed from Android to Adblock Browser for Android
See #2673
comment:7 Changed on 05/12/2016 at 11:48:52 AM by diegocarloslima
- Owner set to diegocarloslima
- Tester set to Unknown
comment:8 Changed on 05/12/2016 at 12:30:47 PM by diegocarloslima
- Status changed from new to reviewing
comment:10 Changed on 09/15/2016 at 01:53:01 PM by diegocarloslima
- Ready set
comment:11 Changed on 10/17/2016 at 06:03:35 PM by abpbot
A commit referencing this issue has landed:
Issue 2512 - A square to mark and unmark is displayed on the side of "None".
comment:12 Changed on 10/17/2016 at 06:06:15 PM by diegocarloslima
- Blocked By 3820 added
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:13 Changed on 06/19/2017 at 07:50:06 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- There is no longer a checkbox next to 'none' when no filter list is enabled. Instead, the box now shows 'None - Please select one below'.
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
While this was so far by design, I can see how it doesn't really make sense, let's get rid of the check box for "None". Also note how the "None" item is not disabled in the screen shot, that's actually quite confusing that way.