Opened on 05/15/2015 at 04:41:34 AM

Closed on 05/15/2015 at 11:45:22 AM

Last modified on 05/15/2015 at 12:31:06 PM

#2522 closed defect (fixed)

Language dropdown only contains English when visiting English pages

Reported by: Ross Assignee: kzar
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: kzar, trev, saroyanm Blocked By:
Blocking: #2035 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: yes
Review URL(s):

​http://codereview.adblockplus.org/6579774528946176/

Description (last modified by Ross)

Environment

Site: ​https://beta.adblockplus.org (any page).
Browser/OS: Any.

How to reproduce

  1. Visit ​https://beta.adblockplus.org/en/firefox
  2. Select the language drop-down in the header.
  3. Observe it only contains an English entry.
  4. Visit ​https://beta.adblockplus.org/de/firefox
  5. Select the language drop-down in the header.
  6. Observe the full list of languages is now present.

Observed behaviour

When visiting an English language page, the language drop-down only contains an entry for English. When visiting the same page in any other language, the drop-down contains every available language for the page (including English).

Expected behaviour

All languages that are available for the page should be displayed in the drop-down (regardless of which language the user originally visited).

Attachments (1)

Language-Dropdown.png​ (101.2 KB) - added by Ross on 05/15/2015 at 04:41:43 AM.

Download all attachments as: .zip

Change History (6)

Changed on 05/15/2015 at 04:41:43 AM by Ross

comment:1 Changed on 05/15/2015 at 04:42:54 AM by Ross

  • Description modified (diff)

comment:2 Changed on 05/15/2015 at 09:48:37 AM by kzar

  • Cc kzar trev saroyanm added
  • Owner set to kzar
  • Priority changed from Unknown to P2
  • Ready set

Can reproduce as described, broken on new website but works OK on the old one. Taking a look now.

comment:3 Changed on 05/15/2015 at 10:50:59 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 05/15/2015 at 11:45:22 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/cms/rev/51cd63b8c68f

comment:5 Changed on 05/15/2015 at 12:31:06 PM by Ross

  • Verified working set

Fixed. English pages now display all other available languages in the drop-down.

Tested by:
Checking site after running test server with fixed CMS revision.

cms / r43

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.