Opened on 05/18/2015 at 01:42:00 PM
Closed on 05/18/2015 at 01:50:00 PM
Last modified on 05/22/2015 at 08:20:20 PM
#2537 closed defect (fixed)
Don't assume "Chrome/" to be given in the user agent string
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Observed behaviour
In chrome/ext/background.js we detect Chrome >=38, to apply a workaround for https://crbug.com/410382. Therefore the user agent string is parsed, assuming the Chrome version is given after the string Chrome/. However, this code fails on platforms that implement the Chrome extension API but use a different user agent string.
Expected behaviour
The code should consider that case and skip the version comparison and workaround on those platforms.
Attachments (0)
Change History (5)
comment:1 Changed on 05/18/2015 at 01:43:08 PM by sebastian
- Owner set to sebastian
- Summary changed from Don't assume "Chrome/" to be in the user agent string to Don't assume "Chrome/" to be given in the user agent string
comment:2 Changed on 05/18/2015 at 01:43:31 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 05/18/2015 at 01:50:00 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/18/2015 at 01:50:35 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/1d59fb22f4a0