Opened on 05/21/2015 at 07:55:06 AM
Closed on 05/26/2015 at 02:46:02 PM
#2568 closed defect (fixed)
Missing images on blog
| Reported by: | greiner | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Websites | Keywords: | blog |
| Cc: | saroyanm, trev | Blocked By: | |
| Blocking: | #2035 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5930700549128192/ |
||
Description (last modified by greiner)
How to reproduce
- Go to the landing page of one of our blogs: Releases, Development Builds, Blog
- Notice the separator between individual blog posts
- Notice the output in the JavaScript console
- Go to this blog post
- Notice the image on the top of the post
- Notice the output in the JavaScript console
Observed behaviour
- (2,5) Placeholder image is shown for images that failed to load
- (3) A 404 error is shown for the request https://adblockplus.org/images/1.gif
- (6) A 404 error is shown for the request https://adblockplus.org/images/291t.png
Expected behaviour
- (2,5) No placeholder image is shown
- (3,6) No 404 error is shown
Attachments (0)
Change History (8)
comment:1 Changed on 05/22/2015 at 04:36:20 PM by greiner
- Description modified (diff)
- Summary changed from Missing image 1.gif on blog to Missing images on blog
comment:2 Changed on 05/26/2015 at 09:12:47 AM by saroyanm
- Cc saroyanm added
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 05/26/2015 at 09:30:12 AM by saroyanm
- Cc trev @Wladi added
comment:4 Changed on 05/26/2015 at 10:04:40 AM by greiner
- Cc @Wladi removed
comment:5 Changed on 05/26/2015 at 10:56:32 AM by trev
- Owner set to trev
These images belong to the blog, not to Anwiki. They are still on the legacy server of course, the one that is hosting the blog. Unfortunately, we already have a bunch of images in the CMS under static/images/. So I think what we need to do here is:
- Move all images in the CMS under static/images/ to static/img/.
- Make https://adblockplus.org/images/ proxied to the legacy server.
comment:6 Changed on 05/26/2015 at 11:11:17 AM by trev
- Priority changed from P3 to P1
- Review URL(s) modified (diff)
- Status changed from new to reviewing
Broken functionality - definitely P1.
comment:8 Changed on 05/26/2015 at 02:46:02 PM by trev
- Blocking 2035 added
- Resolution set to fixed
- Status changed from reviewing to closed
Pushed:
https://hg.adblockplus.org/web.adblockplus.org/rev/6b5468ed20e7
https://hg.adblockplus.org/infrastructure/rev/16fc43c170f0
Server has been provisioned and the images work again.
Note: See
TracTickets for help on using
tickets.
@Wladimir I can't find this images in anwiki repo I think this images were located in our old Anwiki server, but were outside of repo, I've noticed most of the images from the blog posts were gone, do we still have access to the old server files ? Would it be possible to migrate all images from "images" directory to our new server ? Hope they are still available.