Opened on 05/21/2015 at 10:23:37 AM
Closed on 05/21/2015 at 01:28:11 PM
#2569 closed change (fixed)
Leave errors in chrome.webRequest.onBeforeRequest listener unhandled
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-1.9-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
With #179 we wrapped the chrome.webRequest.onBeforeRequest listener into a try..catch block, considering the behavior introduced with https://crbug.com/349139, cancelling the request when an error occurs in that listener. However, this decision was reverted 15 days later with CL 212693002, and was only visible in the Chrome 35 Canary builds for that short time, but didn't make it into any release version.
What to change
Remove the try..catch block introduced with #179 as work around for https://crbug.com/349139.
Attachments (0)
Change History (4)
comment:2 Changed on 05/21/2015 at 10:27:48 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 05/21/2015 at 01:28:11 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/45305ce40916