Opened on 06/04/2015 at 12:15:52 PM

Closed on 06/08/2015 at 04:51:28 PM

#2634 closed defect (fixed)

URLs in "srcset" attribute aren't considered for element collapsing

Reported by: passbrains Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4734012065054720

Description (last modified by Ross)

Adapted from ​https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-194

Environment

Windows + Vista 64bit + Chrome + English
ABP version Chrome Build 1.8.12.1433

How to reproduce

  1. Install latest ABP extension on Chrome Browser
  2. Load page ​http://www.matchesfashion.com/intl/
  3. Block the image as shown in screenshot1
  4. Refresh the page and Observe screenshot2.

Observed behaviour

Placeholder is shown for blocked image.
For other images on any other websites, placeholder is not shown.

Expected behaviour

Placeholder shall NOT be  shown for blocked image

Attachments (2)

3668_1433179223_women1.jpg​ (92.2 KB) - added by passbrains on 06/04/2015 at 12:15:57 PM.
3668_1433179223_women2.jpg​ (74.6 KB) - added by passbrains on 06/04/2015 at 12:15:58 PM.

Download all attachments as: .zip

Change History (8)

Changed on 06/04/2015 at 12:15:57 PM by passbrains

Changed on 06/04/2015 at 12:15:58 PM by passbrains

comment:1 Changed on 06/04/2015 at 12:16:08 PM by passbrains

1 - 04 Jun 2015 12:15:39 posted by Ross Green
Reproduced.

ABP 1.8.12.1433
Chrome 43.0.2357.81 / Windows Vista x64

comment:2 Changed on 06/04/2015 at 12:20:07 PM by Ross

  • Component changed from Unknown to Platform
  • Description modified (diff)

Sebastian's comment from IRC:

This image doesn't have a "src" but only a "srcset" attribute which isn't considered when collapsing elements.

comment:3 Changed on 06/05/2015 at 02:08:41 PM by sebastian

  • Owner set to sebastian
  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed on 06/07/2015 at 03:07:19 PM by sebastian

  • Summary changed from Placeholder is shown for blocked image to URLs in "srcset" attribute aren't considered for element collapsing

comment:5 Changed on 06/07/2015 at 03:14:38 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 06/08/2015 at 04:51:28 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockpluschrome/rev/94b5e4f34759

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.