Opened on 06/15/2015 at 08:53:29 AM

Last modified on 09/29/2019 at 10:04:20 PM

#2683 reviewing defect

Rietveld mails include reply@codereview-hr.appspotmail.com in various headers

Reported by: matze Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: fhd, fred Blocked By: #2704
Blocking: #2182 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29318010
https://codereview.adblockplus.org/29317154

Description

INFO     2015-06-15 08:46:55,517 mail_stub.py:143] MailService.Send
  From: sebastian@adblockplus.org
  To: d...@adblockplus.org
  To: m...@adblockplus.org
  Cc: t...@adblockplus.org
  Cc: reply@codereview-hr.appspotmail.com
  Reply-to: s...@adblockplus.org, d...@adblockplus.org, m...@adblockplus.org, t...@adblockplus.org, reply@codereview-hr.appspotmail.com
  Subject: Issue 2681 - Fixed: Thunderbird 31 is listed twice on requirements page (issue 29317012 by s...@adblockplus.org)
  Body:
    Content-type: text/plain
    Data length: 813
INFO     2015-06-15 08:46:56,371 xmpp_service_stub.py:110] Sending an XMPP Message:
    From:
       codereview-hr@appspot.com/bot
    Body:
       Comments published by Sebastian Noack: Issue 2681 - Fixed: Thunderbird 31 is listed twice on requirements page
https://codereview.adblockplus.org/29317012/
    Type:
       chat
    Raw Xml:
       0
    To JIDs:
       d...@adblockplus.org

Whatever this is meant for, it is surely not wanted in our current setup.

Attachments (0)

Change History (9)

comment:1 Changed on 06/15/2015 at 08:56:06 AM by matze

  • Owner set to matze

comment:2 Changed on 06/15/2015 at 08:56:25 AM by matze

  • Cc fhd trev fred added
  • Ready set

comment:3 Changed on 06/15/2015 at 08:56:40 AM by matze

  • Component changed from Unknown to Infrastructure
  • Priority changed from Unknown to P2

comment:4 Changed on 06/22/2015 at 08:55:14 AM by matze

  • Blocked By 2704 added

comment:5 Changed on 06/22/2015 at 11:05:32 AM by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 06/22/2015 at 12:56:10 PM by matze

  • Blocking 2703 added

comment:7 Changed on 06/24/2015 at 09:50:09 PM by trev

As noted in the review, we shouldn't fork Rietveld for this - we can override properties of the settings module from the app engine's sandbox. Something like this will work:

  from google.appengine.tools.devappserver2.python.sandbox import
_MODULE_OVERRIDE_POLICIES, ModuleOverridePolicy
  _MODULE_OVERRIDE_POLICIES['settings'] = ModuleOverridePolicy(
      overrides={'RIETVELD_INCOMING_MAIL_ADDRESS': None},
      default_pass_through=True
  )

comment:8 Changed on 09/07/2015 at 07:59:25 AM by matze

  • Blocking 2703 removed

comment:9 Changed on 12/21/2017 at 11:25:42 AM by fhd

  • Cc trev removed

Add Comment

Modify Ticket

Change Properties
Action
as reviewing .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from matze.
 
Note: See TracTickets for help on using tickets.