[meta] Use toolbar icon to indicate that Acceptable Ads are present on current site

[Lain_13]

Background

We currently have 3 primary icons used by ABP:

1. Enabled - red one.
2. Disabled - grey one.
3. Domain is whitelisted - green one.

ABP shows a different icon when it's disabled on a specific domain, but it doesn't inform a user in any way when it allows acceptable ads to load while blocking the rest on specific domain. I think ABP must make it clear by displaying some additional information on the icon (either by showing an icon in a different color or by adding some green/orange border to the red icon, or by adding some indicator to the icon).

What to change

Add indication of acceptable ads whitelist being enabled to the ABP icon if some filter from the whitelist triggered on current page.

[greiner]

Note that the green icon is only available via the Customizations extension so for regular users we only have the red and gray ones. So do you mean that this should be added to Customizations or to Adblock Plus itself?

The main problem I see with this is that the icon would only refer to parts of the site, not to the site as a whole - which is, however, what the icon is supposed to refer to. Therefore it would only make sense to show such an icon if Acceptable Ads completely disables Adblock Plus on a site. As far as I know, there's no site on the whitelist which is completely unblocked, however.

I presume that it would require some other UI element to signal to the user that some elements on the page are part of Acceptable Ads. Preferably it should also be pointing out which ones specifically to avoid confusion due to false negatives and such.

[Lain_13]

Hm... Regarding green icon - true. I don't recall using Customizations extension, though. Was it the defaul behaviour in Firefox previously?

However, I still think there should be some indication on the icon. Maybe some green asterix at the corner or separate counter with number of whitelisted requests. ABP already have number of blocked requests there (and they are related to the parts of the site). And this must be default ABP functionality since acceptable ads is installed by default with it.

Of course it would be nice to be able to highlight whitelisted ads on the page to show what specifically was whitelisted, but that could be hard to do and may require adding some additional metadata into whitelist since ABP wouldn't be able to highlight anything inserted by whitelisted script. So, it could be in plans for distant future. For now indication on the icon should be enough.

[greiner]

Changing the icon needs to be done for each platform individually. Therefore I made this into a meta-ticket for other tickets to block in case we decide to go forward with this idea.

[greiner]

Closing this ticket in favor of ​ui#607.