Opened on 06/15/2015 at 03:17:22 PM
Closed on 02/24/2016 at 09:41:34 AM
Last modified on 03/07/2016 at 07:15:22 AM
#2686 closed defect (fixed)
[Adblock Browser for iOS] - [Bookmarks] - Icons don't update after the website bookmarked has been edited
| Reported by: | Shikitita | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Browser-for-iOS-1.3.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | salsita |
| Cc: | jand, pavelz, vojtab, mario | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by Shikitita)
Environment
Platform: iPhone 5s
Operating System: iOS 8.3
Browser: Adblock Browser 0.7.0
How to reproduce
- With Adblock Browser open, tap on the icon at the bottom right corner of the screen and then tap on the cross in order to open a new tab.
- Tap on the URL bar at the top of the screen where it says "Search or enter website name" and enter a website's address (e.g: youtube.com, google.co.uk or wikipedia.org).
- Tap on the star at the bottom of the screen in order to bookmark that website.
- After this, tap on the icon at the bottom right corner of the screen and then tap on the cross in order to open a new tab.
- Swipe the screen to the left where the bookmarks are and touch and hold the existent bookmark for a few seconds in order for a menu to pop up.
- Select Edit.
- In the following screen change the URL of the bookmarked website for an existing one.
- Tap on "Done" and then tap on the bookmarked website in order to load it.
- Afterwards repeat the steps on number 4 and swipe the screen to the left in order to view the Bookmarks section.
Observed behaviour
The icon of the bookmark does not correspond to the icon of the website bookmarked despite having loaded it after editing it. See the attached screenshot.
Expected behaviour
The bookmark's icon should change to the corresponding one after loading the website.
Attachments (1)
Change History (20)
Changed on 06/15/2015 at 03:17:57 PM by Shikitita
comment:3 Changed on 06/16/2015 at 07:55:28 AM by Shikitita
- Summary changed from [Adblock Browser] - [Bookmarks] - Icons don't update after the website bookmarked has been edited to [Adblock Browser for iOS] - [Bookmarks] - Icons don't update after the website bookmarked has been edited
comment:4 Changed on 06/23/2015 at 10:50:21 AM by philll
- Cc jand pavelz vojtab added
comment:5 Changed on 06/30/2015 at 09:22:36 AM by philll
- Platform changed from Kitt to Adblock Browser for iOS
comment:6 Changed on 07/02/2015 at 04:30:42 PM by pavelz
- Tester set to Unknown
comment:7 Changed on 07/02/2015 at 09:52:28 PM by pavelz
Unusual and uncommon corner case. None of the major iOS browsers reflects changes in already created bookmark. Safari and Chrome keep the previous page title even when the new page is loaded. Opera even does not allow changing URL of an existing bookmark. Neither of the browsers display favicon in the listing.
comment:8 Changed on 07/02/2015 at 10:15:04 PM by pavelz
Interesting philosophical question: if URL is changed and title is changed too (perhaps just simplified), what should happen to the title when the new page is loaded? Should the user editing be thrown away and replaced with the new title? I think that Opera got it right by avoiding the need for such fragile decision logic.
comment:9 Changed on 09/08/2015 at 08:37:50 AM by philll
- Sensitive unset
comment:10 Changed on 10/06/2015 at 07:55:20 AM by mario
- Cc mario added
- Priority changed from Unknown to P4
Lowered priority due to the fact, that ABB behaves like other major browsers for iOS. Nonetheless I see value in this issue and wouldn't discard it. Feel free to discuss it and change the issue to a higher priority.
comment:11 Changed on 10/06/2015 at 07:58:09 AM by mario
- Component changed from Unknown to Adblock-Browser-for-iOS
comment:12 Changed on 10/12/2015 at 11:16:15 AM by mario
- Keywords salsita added
comment:13 Changed on 02/23/2016 at 10:40:06 AM by jand
@mario: I have already implemented this issue. I noticed that it is not marked ready. Can you finalize this issue, please?
comment:14 Changed on 02/23/2016 at 10:47:05 AM by mario
- Ready set
comment:15 Changed on 02/24/2016 at 09:41:34 AM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:16 Changed on 02/26/2016 at 02:07:23 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:17 Changed on 02/29/2016 at 10:26:13 AM by mario
- Milestone Adblock-Browser-for-iOS-next deleted
comment:18 Changed on 03/02/2016 at 02:48:34 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
Rebased the current release branch to include this ticket.
comment:19 Changed on 03/07/2016 at 07:15:22 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- The bookmark's icon changes to the correct icon after loading the website.
ABB 1.3.0-qa (844)
iPhone 6 Plus - iOS 9.2.1
Wrong icons for bookmarks