Opened on 06/16/2015 at 08:44:28 PM
Closed on 03/19/2016 at 03:23:39 PM
Last modified on 04/19/2016 at 11:28:09 PM
#2687 closed defect (fixed)
Shadow DOM breaks layout when using "report a problem" dialog on blogger.com
| Reported by: | mapx | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | goodfirstbug |
| Cc: | sebastian, MSI, Team | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Environment
chrome Version 44.0.2403.39 beta-m (64-bit)
ABP last dev build 1.9.0.1453 or stable 1.9
How to reproduce
Open blogger.com (your blogger account) with Adblock Plus (even without any list)
Click the gear icon button near the top right corner and click "report a problem"
Type something into the text box and click Next (proceeding to the screenshot). Note: Please do not actually submit the report.
Observed behaviour
User interface layout is completely broken and corrupted.
Expected behaviour
The feedback dialog shouldn't corrupt layout, but should behave the same as it does without Adblock Plus.
Attachments (0)
Change History (16)
comment:2 Changed on 06/16/2015 at 09:01:19 PM by MSI Team
comment:3 Changed on 06/16/2015 at 09:02:23 PM by MSI Team
Oops, you just fixed the description issue. Sorry, did not notice until submitted the comment.
comment:4 Changed on 06/18/2015 at 09:21:41 AM by sebastian
- Description modified (diff)
- Keywords firstgoodbug added
- Priority changed from Unknown to P3
- Ready set
For reference, this issue follows up on #2602 which fixed that bug on Google Mail and other websites under the *.google.com domain, by not injecting a shadow root on those websites. This check would need to be extended to also cover blogger.com. Also see the responsible Chromium bug.
comment:5 Changed on 06/18/2015 at 09:21:59 AM by sebastian
- Keywords goodfirstbug added; firstgoodbug removed
comment:6 Changed on 06/18/2015 at 09:36:55 PM by MSI Team
Please ignore comment:2.
Currently Affected:
Blogger.com
Youtube.com ?
Previously Affected but Fixed:
mail.google.com
inbox.google.com
productforums.google.com
Unaffected or Coincidentally Fixed by Fixing Google.com:
Other *.google.com domains
comment:7 Changed on 07/09/2015 at 01:17:56 AM by MSI Team
Any progress?
comment:8 Changed on 07/27/2015 at 08:34:39 PM by MSI Team
Anyone around?
comment:9 Changed on 08/13/2015 at 06:50:22 PM by MSI Team
Any response?
comment:10 Changed on 09/15/2015 at 04:15:21 AM by MSI Team
Bump. Can someone please respond?
comment:11 Changed on 01/21/2016 at 01:37:34 PM by sebastian
- Priority changed from P3 to P4
- Tester set to Unknown
It's unlikely that blogger.com will be the last website where using Shadow DOM will break functionality. So while I'd be fine with adding blogger.com to the websites where we don't use Shadow DOM (patches are welcome), this isn't a sustainable solution.
But also considering #3356 and #3185, which are also related to injecting a stylesheet into the page, I think the long-term solution would be to migrate to chrome.tabs.insertCSS, once frame IDs are supported.
comment:12 Changed on 03/19/2016 at 03:07:17 PM by sebastian
- Owner set to sebastian
- Priority changed from P4 to P3
While chrome.tabs.insertCSS allows to target specific frames meanwhile, it injects not only an author stylessheet, but also one with lower priority than any sylesheet in the DOM. Hence that API is still useless. So unfortunately, Shadow DOM remains still the best option we have to hide elements on websites.
comment:13 Changed on 03/19/2016 at 03:09:03 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:14 Changed on 03/19/2016 at 03:21:54 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/5f8e71b0e90d
comment:15 Changed on 03/19/2016 at 03:23:39 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:16 Changed on 04/19/2016 at 11:28:09 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Feedback UI on blogger.com now looks/works correctly when ABP is installed.
ABP 1.11.0.1597
Chrome 32 / 44 / 48 / Windows 8
Chrome 44 / Ubuntu 14.04
Sorry for the misunderstanding. Unable to reproduce the user interface layout corruption issue on Blogger feedback. However, Adblock Plus is blocking Blogger feedback before it even launches.
As far as I know Gmail is completely unrelated to this issue except maybe it is also affected?