Opened on 06/26/2015 at 09:32:03 AM
Closed on 07/29/2015 at 03:48:28 PM
Last modified on 09/16/2015 at 04:58:56 PM
#2726 closed change (fixed)
Reuse texts from Firefox version for Platform notification opt-out
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.9.3-for-Chrome-Opera-Safari-next |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | #2193, #2195 | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In #2195 we added a global notification opt-out to Chrome/Opera/Safari but couldn't reuse the texts from the Firefox version yet due to #2193 not being done. Therefore the adblockpluschrome repository contains duplicate texts which need to replaced with the ones from the Firefox version.
What to change
- Remove these strings from _locales/en_US/messages.json
- overlay_notification_closing_button_hide
- overlay_notification_closing_button_optout
- overlay_shownotifications_label
- Import these strings from the adblockplus repository's overlay.dtd by adding them to metadata.common
- notification.closing.button.hide
- notification.closing.button.optout
- shownotifications.label
Attachments (0)
Change History (5)
comment:1 Changed on 06/26/2015 at 09:34:31 AM by greiner
- Component changed from User-Interface to Platform
comment:2 Changed on 07/28/2015 at 05:39:28 PM by greiner
- Owner set to greiner
- Tester set to Unknown
comment:3 Changed on 07/29/2015 at 10:43:13 AM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 07/29/2015 at 03:48:28 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 09/16/2015 at 04:58:56 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/9df2c646c422