Opened on 06/26/2015 at 02:58:27 PM
Closed on 08/29/2019 at 05:43:52 PM
#2727 closed change (rejected)
Add return value to Notification.toggleIgnoreCategory()
| Reported by: | greiner | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
In #2192 we implemented Notification.toggleIgnoreCategory(...) to start/stop ignoring notification categories. However, the UI still needs to find out itself what the resulting value is by doing Prefs.notifications_ignoredcategories.indexOf(...) != -1. This could be avoided by returning the result when using Notification.toggleIgnoreCategory.
What to change
- Add boolean return value to Notification.toggleIgnoreCategory() which should be true if the passed category is being ignored after toggling or false otherwise.
- Add unit tests to check return value
- Make use of return value in adblockplus and adblockpluschrome
Attachments (0)
Change History (1)
comment:1 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.