Opened on 07/15/2015 at 12:32:34 PM

Last modified on 08/15/2017 at 11:52:58 AM

#2791 new change

[build] Improve build configuration and build for more targets

Reported by:	rjeschke	Assignee:
Priority:	P3	Milestone:
Module:	Adblock-Browser-for-Android	Keywords:	2015q4
Cc:		Blocked By:	#4677
Blocking:		Platform:	Adblock Browser for Android
Ready:	no	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):

Description (last modified by fhd)

Background

We are currently only producing two different builds: store and standalone - the only difference being that the former disables the built-in updater.

We need to support as many targets as possible - we don't even support x86 devices currently. And there might be some important flags we should be setting on release builds, but don't set yet.

What to change

Add x86 builds to adblockbrowser-build.
Consider adding builds for API<11 - Mozilla appears to do that.
Look into /mobile/android/config/mozconfigs to see if Mozilla is building for other targets we currently don't build for.
Check for additional flags the mozconfigs should also contain.
Check if we need an Adjust SDK token or if we can disable this.

Not set to Ready - we first need to figure out what exactly we want to do.

Change History (11)

comment:1 Changed on 07/15/2015 at 12:34:22 PM by rjeschke

Description modified (diff)

comment:2 Changed on 07/15/2015 at 12:51:45 PM by rjeschke

Description modified (diff)

comment:3 Changed on 10/02/2015 at 11:29:44 AM by fhd

Description modified (diff)
Priority changed from P2 to P3
Ready unset
Summary changed from [Meta] Automated builds and releases to Build Adblock Browser for more targets (e.g. x86)

We already have build automation for everything we release (four different builds: release and devbuilds, both with an without updater), along with proper mozconfigs, in the adblockbrowser-build repository. So I've repurposed this issue to look into what _additional_ builds we need to produce.

I've created a follow-up for creating Adblock Browser devbuilds using buildbot: #3151.

comment:4 Changed on 10/02/2015 at 11:31:03 AM by fhd

Description modified (diff)
Summary changed from Build Adblock Browser for more targets (e.g. x86) to Improve Adblock Browser build configuration and build for more targets

comment:5 Changed on 10/02/2015 at 11:33:24 AM by fhd

Description modified (diff)

comment:6 Changed on 10/02/2015 at 11:33:58 AM by fhd

Description modified (diff)

comment:7 Changed on 10/02/2015 at 11:35:56 AM by fhd

Description modified (diff)

Moved the permission-specific part to #2565.

comment:8 Changed on 10/02/2015 at 11:38:43 AM by fhd

Summary changed from Improve Adblock Browser build configuration and build for more targets to [build] Improve build configuration and build for more targets

comment:9 Changed on 11/16/2015 at 01:48:40 PM by mario

Keywords 2015q4 added

comment:10 Changed on 11/30/2016 at 01:46:47 PM by diegocarloslima

Blocked By 4677 added

comment:11 Changed on 08/15/2017 at 11:52:58 AM by diegocarloslima

For x86 .apk variants, this is already possible with #4677. We might wanna build an arm64 variant as well in the near future.
We shouldn't focus building for API < 15, which is Firefox current minSdkVersion
We might wanna to include .../mozconfigs/common and .../mozconfigs/common.override in our generated mozconfig
There are some API/SDK keys/tokens that we might want to configure such as:

ac_add_options --with-mozilla-api-keyfile=/builds/mozilla-fennec-geoloc-api.key
ac_add_options --with-adjust-sdk-keyfile=/builds/adjust-sdk.token
export SOCORRO_SYMBOL_UPLOAD_TOKEN_FILE=/builds/crash-stats-api.token
...
MOZ_ANDROID_GCM_SENDERID=965234145045

Context Navigation