Opened on 07/16/2015 at 02:26:24 PM
Closed on 07/17/2015 at 12:06:00 PM
#2796 closed change (fixed)
Add DeveloperIdentifier to the generated Safari extension manifest (Info.plist)
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | trev | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29322519 |
||
Description
Background
So far the Safari Developer ID only had to be given in the update manifest. However, in order to upload an extension to the "new" Safari Extension Gallery for Safari 9+, it also needs to be given in the Info.plist file bundled with the extension.
What to change
Move the logic extracting the developer ID from the Safari Developer Certificate from sitescripts to buildtools and add it by the DeveloperIdentifier key to the generated Info.plist.
Hints for testers
Make sure that Adblock Plus still installs (and works) both on Safari 9 and older versions.
Attachments (0)
Change History (3)
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/buildtools/rev/3a314c32bde7
https://hg.adblockplus.org/sitescripts/rev/4ecdb8e9ebde